fix: replace vague ledger-capture guidance with concrete criteria#5
Open
grzegorznowak wants to merge 2 commits into
Open
fix: replace vague ledger-capture guidance with concrete criteria#5grzegorznowak wants to merge 2 commits into
grzegorznowak wants to merge 2 commits into
Conversation
- /handoff command: 'if needed' → 'that aligns with the direction above' - handoff promptGuidelines: 'if needed' → 'that the next context will need' Both changes replace the ambiguous 'if needed' with phrases that anchor ledger capture to a specific referent the LLM can reason about: the user's explicit direction (command) or the next clean context (autonomous handoff).
Contributor
Author
|
@ofriw a small PR that removes some vagueness from the handoff prompt. Not sure if it will improve anything but I feel like not being strict in this phase is not what we want |
Contributor
|
First review passes, just need a merge with main |
…r-prompt # Conflicts: # handoff/command.ts # handoff/tool.ts
Contributor
Author
|
Merged latest Resolution keeps the notebook terminology/topic reset semantics from main while preserving the concrete handoff anchors from this PR:
Validation:
Merge commit pushed: |
Contributor
Author
|
conflicts resolved @ofriw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the ambiguous "if needed" phrasing in two locations where the LLM is instructed to save ledger entries before calling handoff:
/handoffcommand injected messagehandoffpromptGuidelinesWhy
"If needed" puts the burden on the LLM to guess what "needed" means with no referent. Both replacements give a concrete anchor the LLM can reason against: the user's explicit direction (command path) or the needs of the next clean context (autonomous path).
Files changed
handoff/command.ts— injected user messagehandoff/tool.ts— promptGuidelines bulletCompatibility
Neither string is consumed by any downstream code. The enforcement pipeline (
pendingRequestedHandoff.toolCalled) uses boolean flags only. The injected message is pure LLM prompt text.