Bound Agent Control database connection pool#236
Open
abhinav-galileo wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
54d842f to
ed28d63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pool_pre_ping, bounded pool size/overflow, pool timeout, and rollback-on-return for non-SQLite URLsContext
High-concurrency deployments can exhaust Postgres connections when connection budgets scale implicitly with server replicas. This makes Agent Control's DB connection budget explicit per server process instead of relying on SQLAlchemy defaults.
Defaults:
AGENT_CONTROL_DB_POOL_SIZE=5AGENT_CONTROL_DB_MAX_OVERFLOW=0AGENT_CONTROL_DB_POOL_TIMEOUT_SECONDS=5.0Verification
uv run --package agent-control-server ruff check --config pyproject.toml server/src server/tests/test_config.py server/tests/test_db.pyuv run --package agent-control-server mypy --config-file pyproject.toml server/srcmake server-testcould not complete locally because Docker is unavailable and the shared test fixture requires Postgres onlocalhost:5432.