feat(server): refactor server ingestion to sink#165
Open
namrataghadi-galileo wants to merge 1 commit intofeature/61573-add-telemetry-sinkfrom
Open
feat(server): refactor server ingestion to sink#165namrataghadi-galileo wants to merge 1 commit intofeature/61573-add-telemetry-sinkfrom
namrataghadi-galileo wants to merge 1 commit intofeature/61573-add-telemetry-sinkfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the server observability write path to use the shared
ControlEventSinkabstraction while preserving the existing/api/v1/observability/eventsbehavior and Postgres-backed OSS storage.Added a default OSS server sink that adapts the existing
EventStorewrite path into the shared sink contract.Kept the current
DirectEventIngestorusage stable by allowing existing store-based construction to continue working, while routing writes through sink semantics internally.Scope
User-facing / API changes
/api/v1/observability/eventsrequest/response behavior remains unchanged.IngestResultand API response accounting semantics are preserved.Internal changes
EventStore/Postgres path.DirectEventIngestorto write throughControlEventSinkinternally.EventStoreinputs into the default sink internally.Out of scope
Risk and Rollout
Risk level: Medium
Rollback plan:
DirectEventIngestorto writing directly toEventStore.store(...).Testing
make check(or explained why not)Checklist