feat(sdk): Add telemetry package to support sinks#164
Open
namrataghadi-galileo wants to merge 2 commits intomainfrom
Open
feat(sdk): Add telemetry package to support sinks#164namrataghadi-galileo wants to merge 2 commits intomainfrom
namrataghadi-galileo wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new shared top-level
telemetry/package to hold common telemetry contracts and trace-context primitives used across AgentControl.Refactored the SDK observability write path to use the shared
ControlEventSinkcontract internally while preserving the existing default OSS behavior: queue-backed batching and delivery to/api/v1/observability/events.Aligned telemetry packaging with the existing models/engine bundling pattern so telemetry is vendored into SDK and server builds rather than treated as a separate runtime-only dependency.
Scope
User-facing / API changes
Internal changes
ControlEventSink,SinkResult,BaseControlEventSink, and shared trace-context helpers.Out of scope
/observability/eventsserver ingestion behavior.Risk and Rollout
Risk level: Medium
Rollback plan:
Testing
make check(or explained why not)Checklist