Skip to content

Allow binary agents with partial OS coverage #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ignatov merged 1 commit into from
Feb 9, 2026
+9 −9
Merged

Allow binary agents with partial OS coverage #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,13 +425,13 @@ def validate_agent(
f"Unknown platforms: {', '.join(sorted(unknown_platforms))}"
)

# Check that all OS families have at least one platform
# Warn if not all OS families have at least one platform
provided_os_families = {p.split("-")[0] for p in binary.keys() if p in VALID_PLATFORMS}
missing_os_families = REQUIRED_OS_FAMILIES - provided_os_families
if missing_os_families:
errors.append(
f"Binary distribution must include builds for all operating systems. "
f"Missing: {', '.join(sorted(missing_os_families))}"
print(
f"Warning: {agent_dir} binary distribution is missing builds for: "
f"{', '.join(sorted(missing_os_families))}"
)

for platform, target in binary.items():
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

### Binary Distribution

For standalone executables. **Binary distributions must support all operating systems** (macOS, Linux, and Windows):
For standalone executables. At least one platform is required; providing builds for all operating systems (macOS, Linux, and Windows) is recommended but not mandatory:

```json
{
Expand Down Expand Up @@ -94,7 +94,7 @@ For standalone executables. **Binary distributions must support all operating sy

Supported platforms: `darwin-aarch64`, `darwin-x86_64`, `linux-aarch64`, `linux-x86_64`, `windows-aarch64`, `windows-x86_64`

> **Note**: At minimum, you must provide builds for **darwin** (macOS), **linux**, and **windows**. Providing only one OS (e.g., macOS-only) will fail validation.
> **Note**: Providing builds for all operating systems is recommended. Missing OS families will produce a warning during validation but will not block the build.

### npm Package (npx)

Expand Down Expand Up @@ -190,9 +190,9 @@ Entries are validated against the [JSON Schema](agent.schema.json).
- `linux-aarch64`, `linux-x86_64`
- `windows-aarch64`, `windows-x86_64`

**Cross-platform requirement** (for binary):
- Binary distributions must include builds for **all operating systems**: darwin (macOS), linux, and windows
- At least one architecture per OS is required (e.g., `darwin-aarch64`, `linux-x86_64`, `windows-x86_64`)
**Cross-platform coverage** (for binary):
- Providing builds for all operating systems (darwin, linux, windows) is recommended
- Missing OS families will produce a warning but will not fail validation

**Version matching:**
- Distribution versions must match the entry's `version` field
Expand Down
Loading