fix properly interpolate variables in generate.rs error messages#862
Merged
benbrandt merged 1 commit intoagentclientprotocol:mainfrom Mar 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect error message formatting in
src/bin/generate.rswhere file write failures would display literal placeholder text instead of actual values.Changes
Fixed three locations where
.expect()was used with format string placeholders that were never interpolated:schema_file- Fixed error when writing schema JSONmeta_file- Fixed error when writing metadata JSONdoc_file- Fixed error when writing markdown documentationBefore vs After
Failed to write {schema_file}Failed to write schema.json: Permission deniedTesting