feat(unstable): scaffold session/delete behind unstable_session_delete#1222
Closed
chazcb wants to merge 3 commits into
Closed
feat(unstable): scaffold session/delete behind unstable_session_delete#1222chazcb wants to merge 3 commits into
chazcb wants to merge 3 commits into
Conversation
Adds the `session/delete` method as an unstable schema feature, mirroring how session/list (agentclientprotocol#226) and session/fork (agentclientprotocol#311) first landed. - New `unstable_session_delete` feature flag (Cargo.toml). - `DeleteSessionRequest`/`DeleteSessionResponse` structs in v1 and v2 (currently empty aside from `_meta` — fields TBD). - `SessionDeleteCapabilities` and `sessionCapabilities.delete`. - `session/delete` method name, AgentMethodNames entry, ClientRequest /AgentResponse variants, generate.rs routing. - v2 conversion impls + SessionCapabilities arm. - RFD revision-history entry. Schema regeneration (npm run generate) and field choices to follow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- DeleteSessionRequest now carries `session_id: SessionId` (v1, v2); constructor takes the id, matching CloseSessionRequest. - v2 conversion threads session_id through. - Add round-trip serialization test and capabilities builder test. - Fix `session.delete` -> `sessionCapabilities.delete` in variant docs. - Bump RFD revision-history date. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Output of `npm run generate`: - schema/schema.unstable.json - schema/schema.v2.unstable.json - schema/meta.unstable.json - schema/meta.v2.unstable.json - docs/protocol/draft/schema.mdx - docs/protocol/draft/schema-v2.mdx Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Hmm i think I beat you to it last night? With #1216? |
Contributor
Author
You beat me to it!! Ty @benbrandt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scaffolds
session/deleteas the unstable schema featureunstable_session_delete, mirroring howsession/list(#226) andsession/fork(#311) first landed. The session-delete RFD was moved to Draft; this is the implementation step.unstable_session_deletefeature flag (in theunstableumbrella).DeleteSessionRequest(carriessessionId: SessionId) /DeleteSessionResponse, mirrored in v1 and v2.SessionDeleteCapabilitiesandsessionCapabilities.deletebuilder.AgentMethodNames.session_delete,ClientRequest/AgentResponsevariants, generate.rs routing.SessionCapabilitiesarms.Question for reviewers
session/list updated
docs/protocol/initialization.mdxSession Capabilities when it landed unstable; session/fork did not. Should this PR add a paragraph toinitialization.mdxfordeletenow, or defer until the Preview move? Happy either way.Test plan
🤖 Generated with Claude Code