Add doc/ to the target in Makefile and make the cabal command customizable#2830
Merged
MatthewDaggitt merged 7 commits intoagda:masterfrom Oct 31, 2025
Merged
Add doc/ to the target in Makefile and make the cabal command customizable#2830MatthewDaggitt merged 7 commits intoagda:masterfrom
doc/ to the target in Makefile and make the cabal command customizable#2830MatthewDaggitt merged 7 commits intoagda:masterfrom
Conversation
JacquesCarette
approved these changes
Sep 22, 2025
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
I'm fine with the output of GenerateEverything going (back) to doc/, assuming everything else keeps working. But definitely @gallais and @MatthewDaggitt need to also look at this.
Contributor
Author
|
I believe GenerateEverything already puts Everything.agda in doc since #2184. This PR does not change its |
Collaborator
|
This seems a reasonable set of changes to me! |
Contributor
Author
|
@gallais For the change from |
andreasabel
reviewed
Oct 3, 2025
Contributor
Author
|
I think this is ready. |
JacquesCarette
approved these changes
Oct 27, 2025
andreasabel
approved these changes
Oct 28, 2025
Member
andreasabel
left a comment
andreasabel
left a comment
There was a problem hiding this comment.
A sorry, I seemed to have blocked this with my review.
Changes accepted!
plt-amy
pushed a commit
that referenced
this pull request
Feb 9, 2026
…tomizable (#2830) * Add stack yaml for GHC 9.10.2 (stackage lts-24.11) * Fix Everything.agda targets in Makefile * Allow customization of the cabal command * Bump CI tag to Agda v2.8.0 (not RCs) * Fix CABAL_EXEC variable name * Update stack-9.10.2 to 9.10.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits include two changes:
doc/prefix to theEverything.agdatargets in GNUmakefilecabala makefile variable, thus allowing the user to substitute a different command (or designate a specific binary).I believe (1) is a leftover of #2184. This change stops two consecutive
make listingscalls from re-generating the documentation.(2) allows the user to use custom commands, e.g. using stack:
However,
fix-whitespace,check-whitespaceandtestseem to be cabal-specific, so I only make the cabal path customizable.CI: shhyou#1