Skip to content

feat: add return_type csv #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afuetterer merged 1 commit into from
Dec 11, 2024
Merged

feat: add return_type csv #182

afuetterer merged 1 commit into from
Dec 11, 2024

Conversation

@afuetterer
Copy link
Owner

@afuetterer afuetterer commented Aug 20, 2024 •
edited
Loading

Fixes #124

Tasks

  • add pandas to optional dependencies
  • add return type csv (str)
  • add return type dataframe (pandas.DataFrame)
  • add pandas to dependencies list in docs
  • add return types to readme
  • rebase branch
  • deal with pandas in type hinter, which results in error
  • handle missing import of optional dependency
  • add tests
    • cli
    • client
  • mypy passes
    • add DataFrame return type to dispatch function
  • squash all the commits

@afuetterer afuetterer added the type: feature New feature or request label Aug 20, 2024
Repository owner deleted a comment from github-actions bot Dec 9, 2024
@afuetterer afuetterer force-pushed the 124-csv branch 2 times, most recently from 4940d82 to da8a2c3 Compare December 10, 2024 21:25
@afuetterer afuetterer merged commit 4123823 into main Dec 11, 2024
13 checks passed
@afuetterer afuetterer deleted the 124-csv branch December 11, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add return_type csv

1 participant

@afuetterer