[CLIENT-3466] Raise an exception if a Python integer is out of bounds when converted to a fixed length integer#935
Open
DomPeliniAerospike wants to merge 30 commits intodevfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #935 +/- ##
==========================================
- Coverage 83.89% 83.04% -0.85%
==========================================
Files 99 99
Lines 14514 14666 +152
==========================================
+ Hits 12176 12180 +4
- Misses 2338 2486 +148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
juliannguyen4
changed the title
Added helper functions Fixed some bugs from previous implementation
…hub.com/aerospike/aerospike-client-python into CLIENT-3466-Length-Check-Fixed-Integers
Fixed test case which returned different error string for py 3.14 Changed error message to more accurate description of the failure.
for more information, see https://pre-commit.ci
…ck-Fixed-Integers
for more information, see https://pre-commit.ci
…ck-Fixed-Integers
…ck-Fixed-Integers
…ck-Fixed-Integers
…ut to be a pylong or else segv can occur
…ck-Fixed-Integers
…ck-Fixed-Integers
…ck-Fixed-Integers
… calls take in int64_t for index and rank, so change variable to be the same type. In Windows the C long type is only a signed 32-bit integer, so the integer/rank from Python can get truncated which is also implementation-defined behavior for signed integers
…ck-Fixed-Integers
…ck-Fixed-Integers
…ck-Fixed-Integers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Extra changes
add_op()helper functionManual testing
https://aerospike-python-client--935.org.readthedocs.build/en/935/aerospike_helpers.operations.html#module-aerospike_helpers.operations.map_operations
Massif=false
Massif=true
Build wheels