feat: add countryCodeIgnoreList to site llmo config#1447
Merged
akshaymagapu merged 4 commits intomainfrom Mar 20, 2026
Merged
Conversation
Add per-site country code ignore list configuration for CDN logs reports. This allows sites to specify country codes (e.g., 'PS', 'AD') that should be treated as GLOBAL when extracted from URL paths, avoiding false positives where path segments like '/ps/' don't represent actual country codes. - Add countryCodeIgnoreList Joi schema (array of 2-char uppercase strings) - Add getLlmoCountryCodeIgnoreList() accessor - Add updateLlmoCountryCodeIgnoreList() updater Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
akshaymagapu
force-pushed
the
feat/country-code-ignore-list
branch
from
46771c5 to
a594a06
Compare
Remove .uppercase() Joi constraint since the audit worker already handles case normalization via .toUpperCase(). This allows storing values in any case (e.g., 'ps', 'PS', 'Ps') without validation errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ekremney
approved these changes
Mar 18, 2026
|
This PR will trigger a minor release when merged. |
solaris007
pushed a commit
that referenced
this pull request
Mar 20, 2026
## [@adobe/spacecat-shared-data-access-v3.27.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.26.0...@adobe/spacecat-shared-data-access-v3.27.0) (2026-03-20) ### Features * add countryCodeIgnoreList to site llmo config ([#1447](#1447)) ([6d824f8](6d824f8))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v3.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
countryCodeIgnoreListconfiguration underllmoin site configPS,AD) that should be ignored in CDN logs reports and fall back toGLOBALgetLlmoCountryCodeIgnoreList), and updater (updateLlmoCountryCodeIgnoreList)Context
Some sites have URL path segments like
/ps/that match country code patterns but don't represent actual countries. This config lets admins exclude those codes per-site.Dependent PRs
Test plan
🤖 Generated with Claude Code