feat: experimentation engine by dipratap · Pull Request #1446 · adobe/spacecat-shared

dipratap · 2026-03-18T07:00:32Z

Please ensure your pull request adheres to the following guidelines:

make sure to link the related issues in this description
when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

github-actions · 2026-03-19T00:12:58Z

This PR will trigger a patch release when merged.

nit23uec · 2026-03-19T07:24:48Z

+const DEFAULT_EXPERIMENT_PLATFORMS = ['chatgpt_free', 'perplexity'];
+const PRE_PHASE_CRON_EXPRESSION = '0 * * * *';
+const POST_PHASE_CRON_EXPRESSION = '0 0 * * *';
+const PRE_PHASE_EXPIRY_MS = 10 * 60 * 60 * 1000; // 10 hours


14 hours - to make sure we have 14 runs each for pre and post phase.

nit23uec · 2026-03-19T07:27:58Z

  submitScrapeJob(params: ScrapeJobParams): Promise<DrsJobResult>;
  lookupScrapeResults(params: ScrapeLookupParams): Promise<ScrapeLookupResponse | null>;
  triggerBrandDetection(siteId: string, options?: BrandDetectionOptions): Promise<Record<string, unknown> | null>;
+  submitExperiment(params: SubmitExperimentParams): Promise<ExperimentSubmitResult>;


submitExperiment and getExperimentStatus are not required now

nit23uec · 2026-03-19T07:30:59Z


+  /**
+   * Creates an experiment schedule in DRS and optionally triggers it immediately.
+   * Uses the schedules API instead of legacy experiments API.


there is no legacy experiments API

nit23uec · 2026-03-19T07:32:46Z

+      throw new Error('scheduleId is required');
+    }
+
+    this.log.info('Getting DRS schedule status', { siteId, scheduleId });


this also requires ?include_jobs=true query param

nit23uec

inline comments.

nit23uec · 2026-03-31T04:23:00Z

+    default: 0,
+    validate: (value) => isInteger(value) && value >= 0,
+  })
+  .addAttribute('baselineDate', {


startTime is more standard term.
Pre period is before startTime and post period is after startTime

nit23uec · 2026-03-31T15:09:47Z

+  getSuggestionIds(): string[];
+  getName(): string;
+  getPromptsCount(): number;
+  getBaselineDate(): string | undefined;


getStartTime()

nit23uec · 2026-03-31T15:10:06Z

+  setSuggestionIds(suggestionIds: string[]): GeoExperiment;
+  setName(name: string): GeoExperiment;
+  setPromptsCount(promptsCount: number): GeoExperiment;
+  setBaselineDate(baselineDate?: string): GeoExperiment;


setStartTime

adobe-kodiak · 2026-04-01T09:15:30Z

Kodiak: Security Findings Summary

No new findings introduced in this PR

High priority issues identified within this repository

CVE-2026-25896 (1 finding(s))

Code Path	Lines	Dashboard (Needs VPN)	Direct Dependency	CVE Advisory Info
package-lock.json	1	Manage finding	False	CVE-2026-25896: GHSA, NVD

See all 1 findings for CVE-2026-25896 in Kodiak Dashboard

Quick links: Dashboard Branch Violation Page, Dashboard Home, How does Kodiak track findings and violations?

This kodiak comment is based on the following commits

aaa76ce, 7547129, 525b183, 6384aed, 4fa8f17

Note: This comment will be updated as new commits are pushed to the branch. If finding status changes a new comment will be published. For questions and answers please review Kodiak FAQ or reach out to #kodiak-support on Slack.

Have any feedback for us? Kodiak is always looking to improve our user experience - Let us know how we're doing!

nit23uec · 2026-04-01T10:17:43Z

+  getStatus(): string;
+  getSuggestionIds(): string[];
+  getName(): string;
+  getPromptsCount(): number;


getPromptsLocation() is missing

## [@adobe/spacecat-shared-data-access-v3.37.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.36.1...@adobe/spacecat-shared-data-access-v3.37.0) (2026-04-01) ### Features * experimentation engine ([#1446](#1446)) ([44bff63](44bff63))

solaris007 · 2026-04-01T12:30:46Z

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v3.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# [@adobe/spacecat-shared-drs-client-v1.4.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-drs-client-v1.3.1...@adobe/spacecat-shared-drs-client-v1.4.0) (2026-04-01) ### Features * experimentation engine ([#1446](#1446)) ([44bff63](44bff63))

solaris007 · 2026-04-01T12:31:04Z

🎉 This PR is included in version @adobe/spacecat-shared-drs-client-v1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [@adobe/spacecat-shared-tokowaka-client-v1.13.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.12.3...@adobe/spacecat-shared-tokowaka-client-v1.13.0) (2026-04-01) ### Features * experimentation engine ([#1446](#1446)) ([44bff63](44bff63))

solaris007 · 2026-04-01T12:32:11Z

🎉 This PR is included in version @adobe/spacecat-shared-tokowaka-client-v1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dipratap added 3 commits March 17, 2026 23:38

fix: experimentation engine

3362eee

fix: experimentation engine

eb33d8f

fix: refactor

010252b

nit23uec reviewed Mar 19, 2026

View reviewed changes

Comment thread packages/spacecat-shared-data-access/src/models/geo-experiment/geo-experiment.model.js Outdated

nit23uec reviewed Mar 19, 2026

View reviewed changes

nit23uec requested changes Mar 19, 2026

View reviewed changes

dipratap added 16 commits March 26, 2026 21:59

fix: geo-experiment model schema changes

381bbde

fix: tests

37ccb9b

fix: merge main

b9a7d31

fix: tests

9949fa6

fix: updates

5d84427

fix: merge main

eaa08b5

fix: updates

f74fb20

fix: updates

e6274aa

fix: updates

e709006

fix: minor details

8582cfb

fix: updated flow

df7c12a

Merge branch 'main' of github.com:adobe/spacecat-shared into expe

a195c35

fix: updated flow

5cc898e

fix: updated flow

0b9a73a

fix: merge main

e98f4e2

fix: updated flow

401f7f3

nit23uec reviewed Mar 31, 2026

View reviewed changes

dipratap added 3 commits March 31, 2026 15:25

fix: added completion date

6cf1475

fix: merge main

8889918

fix: update fields

f1467d4

nit23uec reviewed Mar 31, 2026

View reviewed changes

Comment thread packages/spacecat-shared-data-access/src/models/geo-experiment/geo-experiment.schema.js

nit23uec reviewed Mar 31, 2026

View reviewed changes

fix: update fields

6a2b2b8

nit23uec reviewed Apr 1, 2026

View reviewed changes

Comment thread packages/spacecat-shared-data-access/src/models/geo-experiment/geo-experiment.schema.js

dipratap added 2 commits April 1, 2026 14:31

fix: updated db fields

4fa8f17

fix: merge main

6384aed

fix: updated db fields

525b183

nit23uec approved these changes Apr 1, 2026

View reviewed changes

nit23uec reviewed Apr 1, 2026

View reviewed changes

dipratap added 2 commits April 1, 2026 16:45

fix: updated db fields

7547129

fix: merge main

aaa76ce

dipratap merged commit 44bff63 into main Apr 1, 2026
5 checks passed

dipratap deleted the expe branch April 1, 2026 12:21

solaris007 added the released label Apr 1, 2026

nit23uec mentioned this pull request Apr 1, 2026

feat: edge deploy API async support adobe/spacecat-api-service#1980

Merged

Conversation

dipratap commented Mar 18, 2026

Related Issues

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nit23uec left a comment

Choose a reason for hiding this comment

Uh oh!

nit23uec Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adobe-kodiak bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kodiak: Security Findings Summary

No new findings introduced in this PR

High priority issues identified within this repository

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

solaris007 commented Apr 1, 2026

Uh oh!

solaris007 commented Apr 1, 2026

Uh oh!

solaris007 commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nit23uec Mar 31, 2026 •

edited

Loading

adobe-kodiak bot commented Apr 1, 2026 •

edited

Loading