Conversation
the table would also increase the rest of the column widths when trying to shrink a single column in some cases too
|
Build successful! 🎉 |
| ...style, | ||
| tableLayout: 'fixed', | ||
| width: 'fit-content' | ||
| width: 'min-content' |
There was a problem hiding this comment.
Could you add a code comment pointing to the upstream issue? We may want to revisit this once it gets resolved. Also, for future reference, the reason why I didn't suggest the "extended" version of fit-content, e.g. min(max-content, max(min-content, stretch)), is because max-content is actually the value causing the issue - not fit-content itself, which is basically an alias for the above.
|
Build successful! 🎉 |
| ...style, | ||
| tableLayout: 'fixed', | ||
| width: 'fit-content' | ||
| // due to https://bugzilla.mozilla.org/show_bug.cgi?id=1959353, we can't use "fit-content". |
There was a problem hiding this comment.
Can we adde a chromatic story as a test against this? we run against FF there, so should be reproducible
There was a problem hiding this comment.
added the RAC story to the S2 chromatic since we don't have a RAC chromatic. Would've just added a S2 story but our S2 table doesn't actually exhibit the original issue.
|
Build successful! 🎉 |
|
@snowystinger |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:ActionMenu ActionMenu <T extends {}> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
align?: 'start' | 'end' = 'start'
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean
children: ReactNode | (T) => ReactNode
defaultOpen?: boolean
direction?: 'bottom' | 'top' | 'left' | 'right' | 'start' | 'end' = 'bottom'
disabledKeys?: Iterable<Key>
id?: string
isDisabled?: boolean
isOpen?: boolean
isQuiet?: boolean
items?: Iterable<T>
menuSize?: 'S' | 'M' | 'L' | 'XL' = 'M'
onAction?: (Key) => void
onOpenChange?: (boolean) => void
- shouldCloseOnSelect?: boolean
shouldFlip?: boolean = true
size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
styles?: StylesProp
}/@react-spectrum/s2:ActionMenuProps ActionMenuProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
align?: 'start' | 'end' = 'start'
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean
children: ReactNode | (T) => ReactNode
defaultOpen?: boolean
direction?: 'bottom' | 'top' | 'left' | 'right' | 'start' | 'end' = 'bottom'
disabledKeys?: Iterable<Key>
id?: string
isDisabled?: boolean
isOpen?: boolean
isQuiet?: boolean
items?: Iterable<T>
menuSize?: 'S' | 'M' | 'L' | 'XL' = 'M'
onAction?: (Key) => void
onOpenChange?: (boolean) => void
- shouldCloseOnSelect?: boolean
shouldFlip?: boolean = true
size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
styles?: StylesProp
} |
Closes #9865
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the "fixed column width" and "table example" RAC table stories. The fixed column width table should render each of its columns with 100px of width and not fill its wrapping container. Shrinking the width of the "Action" column in the "table example" story should not make the other columns expand in size.
🧢 Your Project:
RSP