fix: SpinButton spins forever if the first change results in a disabled button#9813
Open
snowystinger wants to merge 3 commits intomainfrom
Open
fix: SpinButton spins forever if the first change results in a disabled button#9813snowystinger wants to merge 3 commits intomainfrom
snowystinger wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9676
There are two approaches in this PR. The first commit made the change in useSpinButton and checked the attributes of the button being pressed. If it's disabled, stop the spin.
The second approach was a bit more systematic, I canceled the press event chain if the element was pressed but then was disabled in the pointer up event. This seems more desirable, but I am more cautious since it changes usePress.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: