fix(selection): prevent empty ListBox from stealing focus in Select Popover#9808
Open
albertdugba wants to merge 1 commit intoadobe:mainfrom
Open
fix(selection): prevent empty ListBox from stealing focus in Select Popover#9808albertdugba wants to merge 1 commit intoadobe:mainfrom
albertdugba wants to merge 1 commit intoadobe:mainfrom
Conversation
| const didAutoFocusRef = useRef(false); | ||
| useEffect(() => { | ||
| if (autoFocusRef.current) { | ||
| // Don't autofocus an empty collection. Wait until items are added. |
Member
There was a problem hiding this comment.
I think we can still autoFocus an empty collection, but it's hard to tell the difference between an intentionally empty collection and one that is waiting for the first set of items to appear due to the double render nature of collections.
In addition, this may now steal focus unintentionally if you go from 0 items to N items much later.
I think the solution to this would typically be, if the user knows that it's intentionally empty and they don't want to autoFocus the empty collection, they set autoFocus to false.
I realise this may be harder inside a Select, you could intercept the ListBoxContext and override that property.
Will have to think on this some more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #9803
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: