Skip to content

fix(react-aria-components): pass overlay id to PopoverContext in Dialogue#9807

Open
albertdugba wants to merge 1 commit intoadobe:mainfrom
albertdugba:fix/popover-aria-controls-id
Open

fix(react-aria-components): pass overlay id to PopoverContext in Dialogue#9807
albertdugba wants to merge 1 commit intoadobe:mainfrom
albertdugba:fix/popover-aria-controls-id

Conversation

@albertdugba
Copy link
Contributor

This fixes Issue #9800

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

[PopoverContext, {
trigger: 'DialogTrigger',
triggerRef: buttonRef,
id: overlayProps.id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are sending the id to both DialogContext and PopoverContext. This is causing the test failures. We could potentially set id to undefined on DialogContext and only send it to PopoverContext, but not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants