fix(submenus): restore safe area behavior when submenu mounts #9645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9641
Looks like this broke in a0d9474 when we removed
onResizeas a dependency of the effect inuseResizeObserver. It was only working before because we were passing a new function every render, so it happened to correct itself.This PR updates the ref once the submenu is open, so the ref is no longer null and we can measure the submenu rect.
For test coverage, we'll probably need to include a real browser test later (in #9516).
This PR includes the changes from #9639 so we can test the hover behavior, but that should get merged soon.
✅ Pull Request Checklist:
📝 Test Instructions:
Test the safe area hover behavior in a RAC Submenu story.
🧢 Your Project: