Skip to content

Conversation

@reidbarber
Copy link
Member

Closes #9641

Looks like this broke in a0d9474 when we removed onResize as a dependency of the effect in useResizeObserver. It was only working before because we were passing a new function every render, so it happened to correct itself.

This PR updates the ref once the submenu is open, so the ref is no longer null and we can measure the submenu rect.

For test coverage, we'll probably need to include a real browser test later (in #9516).

This PR includes the changes from #9639 so we can test the hover behavior, but that should get merged soon.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test the safe area hover behavior in a RAC Submenu story.

🧢 Your Project:

@github-actions github-actions bot added the RAC label Feb 11, 2026
@github-actions github-actions bot added the v3 label Feb 12, 2026
@rspbot
Copy link

rspbot commented Feb 12, 2026

@LFDanLu LFDanLu added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit b842443 Feb 12, 2026
29 checks passed
@LFDanLu LFDanLu deleted the fix-submenu-safe-area-resize-observer branch February 12, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pointer-friendly submenu experience is broken for react-aria-components

4 participants