fix(localization): improve Finnish language (fi-Fi) screen reader localizations for combobox#8747
Open
joonaojapalo wants to merge 1 commit intoadobe:mainfrom
Open
Conversation
d8c8ec3 to
19e2adb
Compare
Member
|
Thanks for the PR, I opened a ticket with our translators for verification and alignment across Adobe. I'll update here when I learn more. Sometimes it can take a bit of time, but I haven't forgotten about your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
Included link to corresponding React Spectrum GitHub Issue.Not applcable. I considered not worth opening an issue for tiny linguistic improvement.Added/updated unit tests and storybook for this change (for new code or code which already has tests).Not applicable. Integrity of JSON already being tested by static imports and useLocalizedStringFormatter in useCombobox.Updated documentation (if it already exists for this component).Not applicable.📝 Test Instructions:
Run storybook in related feature branch: