Skip to content

fix: Chromatic flaky popovers and cardview#10117

Open
snowystinger wants to merge 3 commits into
mainfrom
fix-chromatic-flaky-popovers
Open

fix: Chromatic flaky popovers and cardview#10117
snowystinger wants to merge 3 commits into
mainfrom
fix-chromatic-flaky-popovers

Conversation

@snowystinger
Copy link
Copy Markdown
Member

@snowystinger snowystinger commented May 27, 2026

Closes

Fixes animation based flaky tests. Popovers which used animation and skeleton which only didn't move if we set the prefers reduced motion.
I've scoped the prefers reduced motion to just the story that usually breaks, there may be others, but I think in general it's ok to leave alone.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the S2 label May 27, 2026
@snowystinger snowystinger added no testing Does not require manual testing during testing session small review Easy to review PR labels May 27, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented May 27, 2026

@snowystinger snowystinger removed the S2 label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants