fix: Custom 454 Calendar month#10115
Merged
Merged
Conversation
snowystinger
added
release
no testing
|
Build successful! 🎉 |
snowystinger
commented
May 27, 2026
| } | ||
|
|
||
| return formatter.format(startDate.toDate(state.timeZone)); | ||
| // Custom calendars like the 4-5-4 fiscal calendar use getFormattableMonth to map |
Member
Author
There was a problem hiding this comment.
See old path here
LFDanLu
approved these changes
May 27, 2026
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, thanks for figuring out that bug!
yihuiliao
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Looks like the new hooks forgot to include the old logic.
useVisibleRangeDescriptionpath calledstartDate.calendar.getFormattableMonth(startDate)first, which is howCustom454Calendarremaps its internal "month 1" back to the Gregorian month that should be displayed (February).✅ Pull Request Checklist:
📝 Test Instructions:
Covered by Chromatic and now a unit test as well
🧢 Your Project: