fix: ensure Tableview and ListView render their dividers and borders with the proper colors in HCM#10108
Conversation
…with the proper colors in HCM
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| default: 'transparent', | ||
| selectionStyle: { | ||
| highlight: { | ||
| isSelected: 'Highlight' |
Member
There was a problem hiding this comment.
so the problem is things inside the row that aren't text
also, the text should be inverted, this is hard to read
Member
Author
There was a problem hiding this comment.
for posterity: we have fixed the text color, will have to revisit the behavior for where there are arbitrary elements in the row/drag handle where the focus rings blend into the background
|
Build successful! 🎉 |
snowystinger
approved these changes
May 26, 2026
yihuiliao
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via chromatic. I've restored the ListView's selected row background
Highlightcolor in highlight selection to help with visual clarity✅ Pull Request Checklist:
📝 Test Instructions:
Test S2 ListView and TableView in high contrast mode, particularly in highlight selection mode. Make sure the borders/dividers render with ButtonBorder
Also see https://www.chromatic.com/build?appId=651b502f6b74abaae4ee734c&number=102
https://www.chromatic.com/build?appId=651b502f6b74abaae4ee734c&number=103
https://www.chromatic.com/build?appId=651b502f6b74abaae4ee734c&number=104
ignore any non ListView and TableView changes, those are from main
🧢 Your Project:
RSP