fix: RAC modal layout shift when auto-focusing input#10102
Open
nwidynski wants to merge 3 commits into
Open
Conversation
nwidynski
commented
May 25, 2026
Comment on lines
+330
to
+331
| // Hide the modal initially, since an auto-focused input may cause a viewport resize in the next frame. | ||
| // If so, delay the reveal by another frame to avoid layout shift when the viewport settles. |
Contributor
Author
There was a problem hiding this comment.
I tried to squeeze this into the hook layer (e.g. useModalOverlay), but that was challenging, due to expectations around a single render pass. This is also pretty opinionated styling, so I ultimately decided to place it in RAC instead.
nwidynski
commented
May 25, 2026
| preventScrollCount++; | ||
| if (preventScrollCount === 1) { | ||
| if (isIOS()) { | ||
| if (isIOS() && isWebKit()) { |
nwidynski
commented
May 25, 2026
|
|
||
| if (!opts || !opts.preventScroll) { | ||
| scrollIntoViewWhenReady(this, wasKeyboardVisible); | ||
| Reflect.defineProperty(HTMLElement.prototype, 'focus', { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Before vs After
Screen.Recording.2026-05-23.at.11.11.59.PM.mov
Screen.Recording.2026-05-25.at.6.32.24.PM.2.mov
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: