Skip to content

infinite scroll / async loading of big lists#758

Merged
auniverseaway merged 21 commits intomainfrom
biglist
Mar 4, 2026
Merged

infinite scroll / async loading of big lists#758
auniverseaway merged 21 commits intomainfrom
biglist

Conversation

@dkuntze
Copy link
Copy Markdown
Contributor

@dkuntze dkuntze commented Feb 3, 2026

Before: https://main--da-live--adobe.aem.live
After: https://biglist--da-live--adobe.aem.live

Description

This PR implements adobe/da-admin#241 in the UI. The order of merging does not matter. Although, preference to merging 241 first makes logical sense.

Related Issue

adobe/da-admin#241

Motivation and Context

lets customers unlock directories with 1000+ items.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 3, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@dkuntze dkuntze marked this pull request as ready for review February 3, 2026 19:28
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 9, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Comment thread blocks/browse/da-list/da-list.js
Comment thread blocks/browse/da-list/da-list.js Outdated
auniverseaway

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@chrischrischris chrischrischris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

When the list has fully finished loading, I still see the sentinal at the bottom (faint double line). Can we remove it once we're done loading?

If I try to filter for a file before it has loaded, the file never appears. Tested by filtering for "zzz" on https://biglist--da-live--adobe.aem.live/#/revolttv/da-revolt-tv/article with a slowed network connection.

Comment thread blocks/browse/da-list/da-list.css
Comment thread blocks/browse/da-list/da-list.js Outdated
# Conflicts:
#	test/unit/blocks/browse/da-browse/da-browse.test.js
Copy link
Copy Markdown
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool.

@auniverseaway auniverseaway merged commit c3ae780 into main Mar 4, 2026
4 of 5 checks passed
@auniverseaway auniverseaway deleted the biglist branch March 4, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants