This repository was archived by the owner on Sep 2, 2021. It is now read-only.
[REVIEW ONLY] Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image"#424
Open
bchintx wants to merge 2 commits into
Open
[REVIEW ONLY] Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image"#424bchintx wants to merge 2 commits into
bchintx wants to merge 2 commits into
Conversation
Contributor
Author
|
I still need to confirm that this merge module alone is sufficient. I need to build a clean Windows machine on which to test this. Unfortunately, the standard virtual machine images that we have for testing appear to already have the C runtime libraries installed. |
Contributor
|
@bchintx should you close this or maybe test it on a clean vm and see if it's actually needed? |
Contributor
Author
|
@JeffryBooher I've been meaning to build a new Windows machine to test this. Unfortunately, our VMs are not viable test platforms since they already have the C runtime libraries installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image"
Adds Microsoft C runtime library merge module to the WiX script used to produce the Windows installer .msi.