feat: support dev orgs with runtime, in addition to entp#103
Conversation
There was a problem hiding this comment.
🤖 PR Reviewer
The diff cleanly implements org-type filtering at the getOrganizations layer rather than in the prompt-choice helper, which is the right architectural move. The logic is well-documented, error handling is conservative (fail-open for developer orgs), and the test coverage is thorough. There is one minor duplication issue: hasOrgFeature calls sdkClient.getOrganizationFeatures directly instead of delegating to the already-written getOrganizationFeatures method, meaning the error-handling/body-normalisation logic is duplicated.
📝 1 suggestion(s) - Please review inline comments below.
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
There was a problem hiding this comment.
🤖 PR Reviewer
The PR cleanly moves org-type filtering from the pure orgsToPromptChoices helper into LibConsoleCLI.getOrganizations, adds a proper getOrganizationFeatures wrapper, and includes good test coverage. The only remaining issue is the one previously raised: hasOrgFeature duplicates the SDK call and normalisation logic that getOrganizationFeatures already encapsulates, creating two diverging code paths and making the catch block in hasOrgFeature redundant for the body-null case.
🔄 1 re-raised suggestion(s) from previous review
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🤖 PR Reviewer
The previous suggestion about delegating hasOrgFeature to getOrganizationFeatures has been correctly implemented. The new code is well-structured, clearly documented, and thoroughly tested. The fail-open strategy for developer orgs, the constant extraction for org types and feature flags, and the separation of filtering logic from prompt-choice building are all sound design decisions.
✅ LGTM! This PR looks good to merge.
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
Description
Related:
Related Issue
Motivation and Context
How Has This Been Tested?
Locally linked everything and tested with a dev and entp org
aio login aio console org list aio console org select aio app initScreenshots (if appropriate):
Types of changes
Checklist: