Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
v2026.5 May 22nd, 2026

Fixes
gltf
- add input validation to NGP extension to prevent memory corruption vulnerabilities

v2026.3 March 6th, 2026

General Changes:
Expand Down
30 changes: 25 additions & 5 deletions gltf/src/gltfImport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2721,12 +2721,32 @@ importNgpExtension(const tinygltf::Value& ngp, NgpData& ngpData)
if (val.Type() == tinygltf::STRING_TYPE) {
std::vector<uint8_t> data;
unpackBase64String(val.Get<std::string>(), false, data);
dst.resize(data.size() / sizeof(float));

if (d1 == 0 || d2 == 0) {
memcpy(dst.data(), data.data(), data.size());
} else {
std::size_t numFloats = data.size() / sizeof(float);

if (d1 != 0 && d2 != 0) {
std::size_t expectedFloats = d1 * d2;
if (numFloats < expectedFloats) {
TF_WARN("NGP weight data '%s' has %zu floats, expected %zu (d1=%zu, d2=%zu). "
"Skipping.",
name,
numFloats,
expectedFloats,
d1,
d2);
return;
}
dst.resize(expectedFloats);
unpackMLPWeight(reinterpret_cast<const float*>(data.data()), dst.data(), d1, d2);
} else {
if (numFloats == 0) {
TF_WARN("NGP field '%s' decoded to %zu bytes, not enough for a single "
"float. Skipping.",
name,
data.size());
return;
}
dst.resize(numFloats);
memcpy(dst.data(), data.data(), numFloats * sizeof(float));
}
}
};
Expand Down
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "2026.03"
"version": "2026.05"
}
Loading