mergefonts can crash with an all whitespace value#1806
Closed
caolanm wants to merge 1 commit intoadobe-type-tools:developfrom
Closed
mergefonts can crash with an all whitespace value#1806caolanm wants to merge 1 commit intoadobe-type-tools:developfrom
caolanm wants to merge 1 commit intoadobe-type-tools:developfrom
Conversation
echo | mergefonts -cid tests/mergefonts_data/input/cidwhitespace/cidfontinfo.txt Segmentation fault (core dumped) As a minimal fix if the start/end searchs are swapped so that the search for the end of whitespace is done before searching for the start then the new null terminator set by the end search will stop the start search going past the buffer end.
Collaborator
|
This fix is being merged into the addfeatures branch . |
skef
pushed a commit
that referenced
this pull request
Feb 12, 2026
Fixes crash when processing input containing only whitespace characters in font metadata fields. The bug caused a segmentation fault due to buffer overrun in the stringStrip() function. The fix reorders the whitespace trimming operations: the end-of-string search and null terminator placement now happens before the start-of-string search. This prevents the start search from reading past the buffer end when the entire string consists of whitespace. Test case added to verify the fix prevents SIGSEGV on inputs like: FontName ( ) Based on PR #1806 by Caolán McNamara (@caolanm) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
echo | mergefonts -cid tests/mergefonts_data/input/cidwhitespace/cidfontinfo.txt Segmentation fault (core dumped)
As a minimal fix if the start/end searchs are swapped so that the search for the end of whitespace is done before searching for the start then the new null terminator set by the end search will stop the start search going past the buffer end.
Description
Replace this text with a description of your changes, indicating whether
it is a bug fix, enhancement, etc. and which general area(s) are affected
(documentation, specific tool, group of tools, tests, etc.).
If the contribution closes (fixes, resolves) a specific open
issue, please link
the issue.
Checklist: