Implemented unit test to track the visualisation bug in #127.#128
Implemented unit test to track the visualisation bug in #127.#128acataluddi wants to merge 3 commits intoadhocore:mainfrom
Conversation
|
however tests seems failing, please recheck https://github.com/adhocore/php-cli/actions/runs/14956185929/job/42012171472#step:6:48 |
|
another PR #126 is merged already, i will release a new version once this one gets merged too |
Hi Jitendra, Yes, that's "expected" because I've only implemented the unit test reproducing the bug described in #127. I haven't had time to dig into it and I was wondering whether it was immediate for you to continue this branch and figure out the solution, as you know the internals. Thanks, |
|
hi Adriano, unfortunately i am unable to pick it up at this time, i have released new version with other PR. |
Hi Jitendra,
This pull request doesn't solve the bug but rather contains only the unit test method that I believe reproduces the
issue.
I would like you to review and confirm that my understanding of the expected
Table.render()method behaviour iscorrect. Without doubt, the unit test will help validate the actual fixture.
Adriano