feat: add semantic filter type aliases #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ProductFilters, CreativeFilters, and SignalFilters type aliases to resolve name collisions where multiple `Filters` classes exist in different request modules. - ProductFilters: Filters for GetProductsRequest (6 fields for product discovery) - CreativeFilters: Filters for ListCreativesRequest (17 fields for creative library queries) - SignalFilters: Filters for GetSignalsRequest (4 fields for signal discovery) These aliases follow the established pattern in aliases.py for resolving discriminated union name collisions. Upstream schemas now properly define Filter classes as nested objects with properties, so the generator creates proper Pydantic models. Resolves feedback from downstream client regarding Filters type ambiguity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
force-pushed
the
add-filter-type-aliases
branch
from
f270e95 to
9ea76f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds semantic type aliases to resolve name collisions where multiple
Filtersclasses exist in different request modules.Changes
GetProductsRequest.Filters(6 fields for product discovery filtering)ListCreativesRequest.Filters(17 fields for creative library queries)GetSignalsRequest.Filters(4 fields for signal discovery)Implementation
src/adcp/types/aliases.pyfollowing established patternssrc/adcp/__init__.pyfor public APITesting
py_compileContext
Resolves feedback from downstream client regarding
Filterstype ambiguity during 2.9.0 migration. With upstream schemas now properly defining Filter classes, the generator creates proper Pydantic models that we can alias for clarity.🤖 Generated with Claude Code