feat: add create_media_buy, update_media_buy, and build_creative to SimpleAPI #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…impleAPI The SimpleAPI was missing three methods that are available in the full ADCPClient: - create_media_buy: Create a new media buy reservation - update_media_buy: Update an existing media buy reservation - build_creative: Generate production-ready creative assets These methods follow the same pattern as other SimpleAPI methods: - Accept kwargs instead of typed request objects - Return unwrapped response data directly - Raise ADCPSimpleAPIError on failures - Include usage examples in docstrings Also updated test_simple_api_methods to verify all three new methods exist and are async functions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added three missing AdCP protocol methods to the SimpleAPI:
create_media_buy,update_media_buy, andbuild_creative. These methods follow the established SimpleAPI pattern of accepting kwargs, returning unwrapped responses, and raising exceptions on errors.Changes
create_media_buy()for creating new media buy reservationsupdate_media_buy()for updating existing media buy reservationsbuild_creative()for generating production-ready creative assetsTest Plan
🤖 Generated with Claude Code