feat: add missing AdCP protocol methods to CLI and client #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the list_tools protocol introspection command in the CLI. Previously, list_tools was available as a client method but was not exposed through the CLI tool dispatch system. Changes: - Add list_tools to TOOL_DISPATCH table in __main__.py - Handle list_tools specially since it takes no parameters and returns list[str] - Fix TaskResult success field to be False when status is FAILED - Add comprehensive tests for list_tools dispatch and invalid tool names Fixes issue where CLI did not expose the list_tools introspection method that is available on the ADCPClient class. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds four missing AdCP protocol methods that had schemas but were not implemented in the Python client: - preview_creative (existed in client, now added to CLI) - create_media_buy (new to both client and CLI) - update_media_buy (new to both client and CLI) - build_creative (new to both client and CLI) Changes: - Add missing request/response type imports to client.py - Implement create_media_buy, update_media_buy, build_creative in ADCPClient - Add abstract methods to base protocol adapter - Implement methods in MCP and A2A adapters - Add all four tools to CLI TOOL_DISPATCH table with lazy type initialization All 14 AdCP protocol tools are now fully supported in both the client API and CLI interface. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
changed the title
- Add assertions for preview_creative, create_media_buy, update_media_buy, build_creative in test_all_client_methods - Document that complex schema methods are tested separately - Ensures all 4 new client methods are verified to exist Addresses code review feedback on test coverage.
- Add detailed contextual descriptions for create_media_buy, update_media_buy, and build_creative - Include comprehensive parameter explanations with field breakdowns - Add usage examples demonstrating typical patterns - Document response structure and expected data fields - Explain discriminated union usage in update_media_buy Improves developer experience by providing clear guidance on when and how to use these protocol methods.
- Add 'Workflow Examples' section demonstrating end-to-end usage - Document complete media buy workflow (discovery → create → update) - Document complete creative workflow (list formats → preview → build) - Show integrated multi-agent workflow combining both - Reorganize 'Available Tools' section to group Creative Management methods - Include code examples with clear step-by-step comments Makes it easier for developers to understand typical usage patterns and how different protocol methods work together in real-world scenarios.
The upstream AdCP schemas changed: - create_media_buy_response and update_media_buy_response now use the canonical Package type instead of defining custom types - get_signals and activate_signal changed 'destinations' field to 'deployments' - New schema types: asset-content-type, format-category Changes: - Remove obsolete AffectedPackage type (replaced by canonical Package) - Remove obsolete CreatedPackageReference alias (schema now uses full Package everywhere) - Update type imports in stable.py, __init__.py, and aliases.py - Regenerate types from latest schemas - Update test data to use 'deployments' instead of 'destinations' - Update package alias tests to reflect unified Package type All 297 tests passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
list_toolswas implemented in the client but missing from CLIpreview_creativehad types but wasn't exposed through CLIcreate_media_buy,update_media_buy,build_creativewere completely missingChanges
All 14 AdCP protocol tools are now fully supported in both client API and CLI.
Testing