feat: add AdCPBaseModel with exclude_none serialization #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokelley
changed the title
AdCP JSON schemas use `additionalProperties: false` and don't allow null for optional fields. Optional fields must be omitted entirely when not present. Changes: - Create AdCPBaseModel base class with exclude_none=True by default - Update code generator to use AdCPBaseModel instead of BaseModel - Regenerate all models with new base class - Export AdCPBaseModel from adcp.types This ensures spec-compliant JSON serialization where None values are omitted from the output instead of being sent as null. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add proper type annotations to model_dump() and model_dump_json() to satisfy mypy strict type checking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
force-pushed
the
exclude-none-base-model
branch
from
26d3ed6 to
bdccada
Compare
bokelley
added a commit
that referenced
this pull request
Nov 18, 2025
* feat: add AdCPBaseModel with exclude_none serialization AdCP JSON schemas use `additionalProperties: false` and don't allow null for optional fields. Optional fields must be omitted entirely when not present. Changes: - Create AdCPBaseModel base class with exclude_none=True by default - Update code generator to use AdCPBaseModel instead of BaseModel - Regenerate all models with new base class - Export AdCPBaseModel from adcp.types This ensures spec-compliant JSON serialization where None values are omitted from the output instead of being sent as null. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: add type annotations to AdCPBaseModel methods Add proper type annotations to model_dump() and model_dump_json() to satisfy mypy strict type checking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
AdCPBaseModelbase class that ensures spec-compliant JSON serialization where optional fields withNonevalues are omitted entirely rather than sent asnull. Updates all generated models to use this base class.Changes
AdCPBaseModelthat defaultsexclude_none=Trueinmodel_dump()andmodel_dump_json()AdCPBaseModelinstead ofBaseModelAdCPBaseModelfromadcp.typesTesting
All 180 tests pass, including new serialization behavior verification.