simplify startup message printing#11010
Merged
Merged
Conversation
Collaborator
|
Tested on Macropad RP2040 with a recent alpha artifact. Boot.py suppression works — custom display content shows up without boot.py output appearing on screen. The firmware header lines (version, board ID, UID, "boot.py output:") still flash briefly before code.py takes over, but that's printed before boot.py runs so probably out of scope here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print startup messages later so they can be suppressed if desired. Also simplifies the logic of printing them.
I tested on two Metro M0's: the messages still seem to be printed in the same order, and if I go into user-initiated safe mode, they are still the same. I also wrote a blink program on both and tested with USB power only but no data, and they still work. Also
boot.pycontent is still the same.'I am not sure why the original code was more complicated and what case the code after
#if CIRCUITPY_AUTORELOAD_DELAY_MS > 0was trying to handle that the current code may not, but it seems OK with the changes.@mikeysklar could you review test on Macropad or similar to see if this allows what the original issue desired?