support CIRCUITPY_SDCARD_USB in settings.toml#10996
Open
dhalbert wants to merge 2 commits into
Open
Conversation
…n settings.toml Document CIRCUITPY_SDCARD_USB and rework settings.toml documentation
3e171d2 to
fea7505
Compare
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings.toml:CIRCUITPY_SDCARD_USB.true(the default), presents a mounted SD card (auto or manually mounted) via USB MSCfalse, the SD card is not presented over USB.docs/environment.rstto bring it up to date and clarify how it works. DocumentsCIRCUITPY_SDCARD_USBas well.Tested on a Fruit Jam, Metro ESP32-S3, and PyPortal.
@tannewt FYI:
I deleted the lines belowin
tud_msc_test_unit_ready_cb, because they did not seem to be necessary. There are other places whereautomount_sd_card()is called which cause an SD card to be mounted, and I'm not sure why it's called here too.circuitpython/supervisor/shared/usb/usb_msc_flash.c
Lines 375 to 380 in e512a25
I tested this deletion on a Fruit Jam: the SD card is still mounted (when
CIRCUITPY_SDCARD_USBis notfalse) whencode.pyruns, and also when there is not even acode.pyto run. Let me know if you remember what use case this was covering that I missed.Tagging @bablokb and @mikeysklar for interest re #10983, and also for testing if you would like to.