fourwire_construct no reset pin must be mp_const_none, not NULL#10995
Open
dhalbert wants to merge 1 commit intoadafruit:10.2.xfrom
Open
fourwire_construct no reset pin must be mp_const_none, not NULL#10995dhalbert wants to merge 1 commit intoadafruit:10.2.xfrom
dhalbert wants to merge 1 commit intoadafruit:10.2.xfrom
Conversation
Collaborator
Author
|
@oenone tested (#10993 (comment)) and this fix works for them. |
Collaborator
Author
|
This will be in 10.2.1, and I will do a release very soon, since this bug affects quite a few boards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common_hal_fourwire_fourwire_construct()was changed in #10783 to take objects in general rather than only pin objects. If the display reset pin was not present, it expectedmp_const_none, not the previous NULL or MP_OBJ_NULL (both are zero). This caused a crash on all boards that did not use a reset pin for the display.Thanks @oenone for tracking down the exact commit, which made the diagnosis easy.