Conversation
anonrig
approved these changes
Feb 25, 2026
hynek
reviewed
Feb 27, 2026
| self.password = password | ||
| return ret | ||
| duplicate = deepcopy(self) | ||
| duplicate.password = '' |
There was a problem hiding this comment.
If I may be annoying one last time: this way it's not obvious from the outside whether there's a password set or not. How about using a placeholder that indicates the presence of data like [...]?
Suggested change
| duplicate.password = '' | |
| duplicate.password = '[...]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More on issue #127, this PR switches to making a copy of the whole object to avoid introducing thread safety issues.