feat: ship npm twin (@activeadmin-plugins/activeadmin_calendar)#2
Merged
Conversation
Bundler-based asset pipelines (Vite, esbuild, cssbundling-rails, webpacker) cannot resolve assets from Ruby gem paths, so the CSS component of this gem has to be reachable as an npm package for those consumers. Mirrors the layout already used by sibling AA plugins (e.g. @activeadmin-plugins/active_admin_sidebar): a thin package.json with `style` + `main` pointing at src/activeadmin_calendar.css, populated on publish by the `prepublishOnly` script which copies from app/assets/stylesheets/. src/ is gitignored — it only exists at publish time, so the gem and npm package share a single CSS source. Propshaft / Sprockets consumers continue to auto-discover the CSS directly from app/assets/stylesheets/ — they don't need the npm package. Consumers on a bundler can now write: @import '@activeadmin-plugins/activeadmin_calendar'; instead of mirroring the CSS locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundler-based asset pipelines (Vite, esbuild, cssbundling-rails, webpacker) cannot resolve assets from Ruby gem paths, so the CSS component of this gem has to be reachable as an npm package for those consumers.
Mirrors the layout already used by sibling AA plugins (e.g. @activeadmin-plugins/active_admin_sidebar): a thin package.json with
style+mainpointing at src/activeadmin_calendar.css, populated on publish by theprepublishOnlyscript which copies from app/assets/stylesheets/. src/ is gitignored — it only exists at publish time, so the gem and npm package share a single CSS source.Propshaft / Sprockets consumers continue to auto-discover the CSS directly from app/assets/stylesheets/ — they don't need the npm package.
Consumers on a bundler can now write:
@import '@activeadmin-plugins/activeadmin_calendar';
instead of mirroring the CSS locally.