[Embed] feat: Add api_key and url parameters for custom embedding ser… #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vices (#137) * feat: Add api_key and url parameters for custom embedding services Allows using OpenAI-compatible APIs (Ollama, custom models) instead of only Typesense Cloud models for embeddings. * test: Add test case for custom embedding service configuration Validates that api_key and url parameters are properly accepted in embed.model_config without throwing exceptions. * fix: Remove invalid embed parameter at collection level - Remove embed from collection config (only exists at field level) - Update CollectionClient and CollectionManager accordingly - Improve test coverage for embed field configuration --------- Co-authored-by: Ahmed EBEN HASSINE <ahmed.eben-hassine@codein.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vices (#137)
Allows using OpenAI-compatible APIs (Ollama, custom models) instead of only Typesense Cloud models for embeddings.
Validates that api_key and url parameters are properly accepted in embed.model_config without throwing exceptions.