Upgrade versions #4
Conversation
WalkthroughThe pull request modifies two files. In the Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
versions.sh (2)
1-6: 🧹 Nitpick (assertive)Add a Shebang for Clarity
Consider adding a shebang (e.g.#!/usr/bin/env bash) at the very top so that the interpreter is explicitly defined. This avoids ambiguity in different shell environments.🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: PG_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 2-2: PATRONI_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 3-3: CITUS_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 4-4: WAL_G_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 5-5: PG_ACOUSTID_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
1-6: 🧹 Nitpick (assertive)Clarify Variable Exposure
The version variables (e.g.PG_VERSION,PATRONI_VERSION, etc.) are defined but not exported. If these are intended for use by downstream scripts or during Docker build (e.g. via sourcing), consider exporting them or adding a comment to clarify their role.🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: PG_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 2-2: PATRONI_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 3-3: CITUS_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 4-4: WAL_G_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 5-5: PG_ACOUSTID_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Dockerfile(1 hunks)versions.sh(1 hunks)
🧰 Additional context used
🪛 Hadolint (2.12.0)
Dockerfile
[info] 65-65: Double quote to prevent globbing and word splitting.
(SC2086)
[info] 65-65: Avoid additional packages by specifying --no-install-recommends
(DL3015)
[warning] 65-65: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
(DL4006)
[warning] 65-65: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
(DL3008)
🪛 GitHub Actions: Build image
Dockerfile
[warning] 3-3: FromAsCasing: 'as' and 'FROM' keywords' casing do not match.
[error] 65-67: E: Unable to locate package postgresql-17-citus-13.0.1. E: Couldn't find any package by glob 'postgresql-17-citus-13.0.1'. E: Couldn't find any package by regex 'postgresql-17-citus-13.0.1'.
🪛 Shellcheck (0.10.0)
versions.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: PG_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 2-2: PATRONI_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 3-3: CITUS_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 4-4: WAL_G_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
versions.sh (1)
1-5: 🧹 Nitpick (assertive)Consider Adding a Shebang or Directive
Since this file is treated as a shell script (or sourced by one), adding a shebang (for example,
#!/usr/bin/env bash) or a clear shell directive at the top would address ShellCheck’s warning and clarify its intended usage. If the file is not meant to be executed directly, a comment indicating this could suffice.🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: PG_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 2-2: PATRONI_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 3-3: WAL_G_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 4-4: PG_ACOUSTID_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Dockerfile(0 hunks)versions.sh(1 hunks)
💤 Files with no reviewable changes (1)
- Dockerfile
🧰 Additional context used
🪛 Shellcheck (0.10.0)
versions.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: PG_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 2-2: PATRONI_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 3-3: WAL_G_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
🔇 Additional comments (1)
versions.sh (1)
1-3: Updated Version Variables Reflect the PR ObjectiveThe version updates for PostgreSQL (
PG_VERSION=17.4), Patroni (PATRONI_VERSION=4.0.5), and WAL-G (WAL_G_VERSION=3.0.5) align with the intended upgrade. Just double-check that any dependent scripts (e.g., your Dockerfile) now reference these new values.🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: PG_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 2-2: PATRONI_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 3-3: WAL_G_VERSION appears unused. Verify use (or export if used externally).
(SC2034)
No description provided.