added delete, search, other optimizations #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search, delete event, and modals for both delete and edit are now done. Delete handles image deletion perfectly fine. Search has the issues of not showing images and not updating properly once an element is deleted. Implement these issues, comment and clean up code, finish edit, add filtering :DDDDDDDDDD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: after merge, delete isnt working again. we have to debug later
delete is done
added a randomId function which allows for elements to be deleted instantly. basically made the deleting process more seamless visually.
also added support for submitting time.
i also ran into some errors while testing. once you upload a certain image file type (eg. .png, .jpg) you can only upload that file type. uploading any other file type results in the server crashing. sometimes the server will crash even with the correct file type as well. working on fixing this should definitely be covered in the next meeting.
we'll be working on filters, edit, and the images issue next meeting hopefully. i'll also work on making the panel more responsive (making it look better on phone/smaller screens) once we're done with all the actual backend stuff.
images of what we have so far: