Conversation
aleclarson
force-pushed
the
feat/ky-client
branch
3 times, most recently
from
e42d28c to
8be147d
Compare
Generate a client that uses this library: https://github.com/sindresorhus/ky
aleclarson
force-pushed
the
feat/ky-client
branch
from
8be147d to
7c8567e
Compare
Since ky has a special ResponsePromise type, the `request` method cannot use async-await syntax and the returned promise must come from ky (so the expected methods are there). This means the securityWorker cannot be supported by the ky client.
aleclarson
force-pushed
the
feat/ky-client
branch
from
3d7ae28 to
5ed1fe4
Compare
aleclarson
force-pushed
the
feat/ky-client
branch
2 times, most recently
from
bf2adbb to
04b800b
Compare
aleclarson
force-pushed
the
feat/ky-client
branch
from
04b800b to
8c770b8
Compare
|
If anyone is interested in using or testing this, it's published to NPM under /cc @hardouinyann @AshotN (since you both reacted) |
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- package.json: Language not supported
- templates/base/http-clients/ky-http-client.ejs: Language not supported
- templates/default/procedure-call.ejs: Language not supported
- templates/modular/procedure-call.ejs: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Is this PR still relevant ? We would love to use ky in particular with the built-in retry mechanism |
|
any progress on this? |
|
@smorimoto should we revisit this? ky is the second most popular client lib after axios |
|
i'm working on a PR for this but i disabled the auto response body parsing until i find the best way to make it optional ((method overload or conditional types) with |
|
ky client that's compatible with latest version #1601 |
4 participants
Generate a client that uses this library: https://github.com/sindresorhus/ky