Skip to content

Recognize clang targeting Windows as "MinGW like" #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmeum wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Open

Recognize clang targeting Windows as "MinGW like" #2020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions absl/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,23 @@ config_setting(
visibility = [":__subpackages__"],
)

config_setting(
name = "windows-clang",
constraint_values = [
"@platforms//os:windows",
],
flag_values = {
"@bazel_tools//tools/cpp:compiler": "clang",
},
visibility = [":__subpackages__"],
)

selects.config_setting_group(
name = "mingw_compiler",
match_any = [
":mingw_unspecified_compiler",
":mingw-gcc_compiler",
":windows-clang",
Copy link
Member

@derekmauro derekmauro Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The seems to be a hack. In some cases hacks are fine, but there is no comment or any trace for a future reader that explains why this strange line is appearing here. Can you explain precisely what the problem is? Would renaming this group make it more clear what its purpose is?

],
visibility = [":__subpackages__"],
)