Abseil test failure on AIX due to some linking error(terminate getting called)#1608
Abseil test failure on AIX due to some linking error(terminate getting called)#1608krushna100 wants to merge 1 commit intoabseil:masterfrom
Conversation
|
Hi Team, |
|
I don't understand the purpose of this or why it fixes an issue or even what the issue is. Since AIX is not a supported platform (https://opensource.google/documentation/policies/cplusplus-support) and this complicates the code, I'd rather not accept this as is. |
|
@derekmauro Regarding complexities, can we have separate section for AIX rules like below, |
|
We sometimes accept PRs for unsupported platforms if they do not complicate the code. This PR introduces unexplained platform specific build flags. It also provides no explanation why it is necessary since everything seemed to be working before. I suspect there is a more generic way of changing the CMake configuration anyway to achieve whatever this PR is meant to achieve. |
|
@derekmauro @krushna100 |
Thank you for your contribution to Abseil!
Before submitting this PR, please be sure to read our contributing
guidelines.
If you are a Googler, please also note that it is required that you send us a
Piper CL instead of using the GitHub pull-request process. The code propagation
process will deliver the change to GitHub.