Fix #1833: Change varchar(1024) fields to TextField#2029
Open
Jayant-kernel wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Fix #1833: Change varchar(1024) fields to TextField#2029Jayant-kernel wants to merge 1 commit intoaboutcode-org:mainfrom
Jayant-kernel wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
d2a043b to
b4977bc
Compare
b4977bc to
df61c28
Compare
9ed931f to
ea13738
Compare
Update ProjectMessage.traceback and CodebaseResource.path to use TextField instead of CharField to prevent 'value too long' errors when scanning packages with long paths or error messages. Changes: - ProjectMessage.traceback: CharField(1024) -> TextField - CodebaseResource.path: CharField(1024) -> TextField Fixes aboutcode-org#1833 Signed-off-by: NullPointer-cell <jayantmcom@gamil.com>
ea13738 to
8a2afb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the crash where the pipeline fails if an error log or file path gets too long (over 1024 characters). I updated the models to use TextField instead of CharField so we don't run into this limit anymore.
Changes
Updated ProjectMessage.traceback to use TextField.
Updated CodebaseResource.path to use TextField.
Included the database migration file.
Verification I reproduced the crash locally using the Bevy package from the issue description. After applying these changes, the pipeline now finishes successfully without the "value too long" error.