Skip to content

Replace runtime assert with explicit TypeError in interrupt handling #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arbaaz123676 wants to merge 2 commits into
base: develop
Choose a base branch
from
+18 −4
Open

Replace runtime assert with explicit TypeError in interrupt handling #4702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f194ab0
Replace runtime assert with explicit TypeError in interrupt handling
Arbaaz123676 Jan 25, 2026
569c72c
Gracefully handle signal setup failure in interruptible
Arbaaz123676 Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/scancode/interrupt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,20 @@ def handler(signum, frame):
raise TimeoutError

try:
create_signal(SIGALRM, handler)
setitimer(ITIMER_REAL, timeout)
return NO_ERROR, func(*(args or ()), **(kwargs or {}))
create_signal(SIGALRM, handler)
setitimer(ITIMER_REAL, timeout)
except (ValueError, TypeError):
# Signals only work in the main thread.
# If we cannot install them, continue without interrupt support.
return NO_ERROR, func(*(args or ()), **(kwargs or {}))

try:
return NO_ERROR, func(*(args or ()), **(kwargs or {}))
except TimeoutError:
return TIMEOUT_MSG % locals(), NO_VALUE
except Exception:
return ERROR_MSG + traceback_format_exc(), NO_VALUE


except TimeoutError:
return TIMEOUT_MSG % locals(), NO_VALUE
Expand Down Expand Up @@ -167,7 +178,10 @@ def async_raise(tid, exctype=Exception):
from http://tomerfiliba.com/recipes/Thread2/
license: public domain.
"""
assert isinstance(tid, int), 'Invalid thread id: must an integer'
if not isinstance(tid, int):
raise TypeError(
f"Invalid thread id: must be an integer, got {type(tid).__name__}"
)

tid = c_long(tid)
exception = py_object(Exception)
Expand Down
Loading