Skip to content

Fix copyright detection for bracket notation [C] and [c] #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
levi42x wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix copyright detection for bracket notation [C] and [c] #4612

levi42x wants to merge 4 commits into from
+16 −0

Conversation

@levi42x
Copy link

@levi42x levi42x commented Nov 20, 2025 •
edited
Loading

Fixes #3659

Normalize bracketed copyright markers [C] and [c] so they are correctly detected.

Summary

  • [C] / [c] were stripped during preprocessing, leaving plain C / c
  • This caused copyright detection to fail
  • Added normalization in prepare_text_line() to convert [C] and [c] to (c) before bracket removal

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Shekhar Suman levi42x@gmail.com

@levi42x levi42x mentioned this pull request Nov 20, 2025
Open
@levi42x
Fix aboutcode-org#3659: Normalize [C] and [c] to (c) in copyright det…
5bcc04c 
…ection

- Normalize [C] and [c] before bracket removal in prepare_text_line()
- Add tests for both [C] and [c] variants

Signed-off-by: Shekhar <shekharsuman0397@gmail.com>
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @levi42x
See comments for some minor changes and we're good to merge.

Address PR feedback: use real copyright examples and remove extra spaces
87932ac 
Signed-off-by: Shekhar Suman <levi42x@gmail.com>
@levi42x
Copy link
Author

levi42x commented Dec 17, 2025

Hi @AyanSinhaMahapatra,
I’ve implemented the suggested updates. The changes are finalized and ready for merge.

Normalize [c] to (c) and update ignorable metadata
d2c22dd 
Signed-off-by: Shekhar Suman <levi42x@gmail.com>
Remove unused bracket sample
390db1a 
Signed-off-by: Shekhar Suman <levi42x@gmail.com>
@levi42x
Copy link
Author

levi42x commented Jan 28, 2026

Hey Ayan,

The remaining CI failure is in (core_tests misc_and_scancode) and appears unrelated to this change.
It fails during scancode CLI execution on Azure (Python 3.14) with a signal/threading error.

All tests related to [C]/[c] normalization and ignorable metadata pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid copyright not detected

2 participants

@levi42x @AyanSinhaMahapatra