Fix #613: avoid selecting unrelated repositories as source repo#841
Open
Monal-Reddy wants to merge 3 commits intoaboutcode-org:mainfrom
Open
Fix #613: avoid selecting unrelated repositories as source repo#841Monal-Reddy wants to merge 3 commits intoaboutcode-org:mainfrom
Monal-Reddy wants to merge 3 commits intoaboutcode-org:mainfrom
Conversation
…ce repo Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Contributor
Author
|
hey @JonoYang could you please review this when you find time, i will make the necessary changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #613
Problem
When running the collect endpoint for
npmpackageinherits@2.0.0, purldb incorrectly detectedpkg:github/substack/node-browserifyas the source repository.This happens because repository URLs extracted from metadata, homepages, or descriptions may include unrelated GitHub links, which are then treated as valid source repositories.
Solution
Add a filter in
get_source_repo()to prefer repository candidates whose repository name overlaps with the package name. If at least one such candidate exists, unrelated repositories are ignored. If none match, the original behavior is preserved.