FINC-1118 Support jOOQ sort Field<?> mappings#55
Merged
Conversation
…ings in new class SortMappingsForJooq
…ings in new class SortMappingsForJooq
ThoSap
commented
Feb 20, 2026
Contributor
Author
There was a problem hiding this comment.
If this class is not used in a non jOOQ BE project, the project will just compile fine.
Contributor
Author
|
ai review |
SirCotare
requested changes
Mar 2, 2026
src/main/java/it/aboutbits/springboot/toolbox/persistence/SortMappings.java
Show resolved
Hide resolved
src/main/java/it/aboutbits/springboot/toolbox/parameter/SortParameter.java
Show resolved
Hide resolved
src/test/java/it/aboutbits/springboot/toolbox/persistence/SortMappingsForJooqTest.java
Show resolved
Hide resolved
ThoSap
commented
Mar 2, 2026
Comment on lines
+8
to
+14
| /// A mapping of sort parameter definitions to their corresponding database columns. | ||
| /// | ||
| /// The values in this map are of type [Object] and are expected to be either: | ||
| /// - [String] - for column names when using Hibernate/JPA | ||
| /// - `org.jooq.Field<?>` - for jOOQ field objects when using jOOQ | ||
| /// | ||
| /// @param <T> the enum type that implements [SortParameter.Definition] |
Contributor
Author
There was a problem hiding this comment.
This is a modern Java 23+ Markdown Javadoc.
We should always use that going forward, as it is much simpler to read and write in plain text, as in HTML Javadocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is made so that jOOQ is an optional dependency if other projects without jOOQ update to a newer Spring Boot Toolbox version.
Needed for https://github.com/aboutbits/finstral-composer-api/pull/522