Skip to content

FINC-1118 Support jOOQ sort Field<?> mappings#55

Merged
ThoSap merged 8 commits intomainfrom
finc-1118-toolbox-jooq-sort-mappings-field-support
Mar 3, 2026
Merged

FINC-1118 Support jOOQ sort Field<?> mappings#55
ThoSap merged 8 commits intomainfrom
finc-1118-toolbox-jooq-sort-mappings-field-support

Conversation

@ThoSap
Copy link
Contributor

@ThoSap ThoSap commented Feb 20, 2026

This is made so that jOOQ is an optional dependency if other projects without jOOQ update to a newer Spring Boot Toolbox version.

Needed for https://github.com/aboutbits/finstral-composer-api/pull/522

@ThoSap ThoSap self-assigned this Feb 20, 2026
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this class is not used in a non jOOQ BE project, the project will just compile fine.

@ThoSap
Copy link
Contributor Author

ThoSap commented Feb 20, 2026

ai review

@ThoSap ThoSap requested a review from SirCotare February 20, 2026 21:52
@ThoSap ThoSap requested a review from SirCotare March 2, 2026 15:55
Comment on lines +8 to +14
/// A mapping of sort parameter definitions to their corresponding database columns.
///
/// The values in this map are of type [Object] and are expected to be either:
/// - [String] - for column names when using Hibernate/JPA
/// - `org.jooq.Field<?>` - for jOOQ field objects when using jOOQ
///
/// @param <T> the enum type that implements [SortParameter.Definition]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a modern Java 23+ Markdown Javadoc.

We should always use that going forward, as it is much simpler to read and write in plain text, as in HTML Javadocs.

https://openjdk.org/jeps/467

Copy link
Contributor

@SirCotare SirCotare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@ThoSap ThoSap merged commit 046ff90 into main Mar 3, 2026
1 check passed
@ThoSap ThoSap deleted the finc-1118-toolbox-jooq-sort-mappings-field-support branch March 3, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants