Skip to content

Fix flaky "terminal maintains functionality with drawer interactions" test #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyTWF wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

Fix flaky "terminal maintains functionality with drawer interactions" test #289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a3163c
Fix flaky "terminal maintains functionality with drawer interactions"…
AndyTWF Apr 8, 2026
dc09344
Remove temporary stress-test CI step
AndyTWF Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/e2e/web-cli/web-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,19 @@ test.describe("Web CLI E2E Tests", () => {
);
await expect(drawer).toBeVisible({ timeout: 5000 });

// Wait for the terminal to stabilize after the drawer resize —
// without this, keystrokes race with xterm's resize/reflow and
// produce escape-code corruption (GGGGG…DDDDD… garbage).
await waitForTerminalStable(page, 1000);

// Terminal should still be functional with drawer open
await page.locator(terminalSelector).focus();
await page.keyboard.type("help");
await page.keyboard.press("Enter");
// Use a non-styled string from help output — bold headers like "COMMON COMMANDS"
// can be garbled by xterm escape codes when the terminal is resized in drawer mode
// The drawer terminal is smaller, so help output may be truncated.
// Match a string that appears in both full and compact help output.
await expect(page.locator(terminalSelector)).toContainText(
"Subscribe to a channel",
"Display help for ably",
{
timeout: 10000,
},
Expand Down
Loading