Open
Conversation
Owner
|
Hey, thanks for the PR. This looks like a safe change to make which is also backwards compatible. Is there a reason why it would be preferable to add this with a filter rather than an an argument to the command? |
This reverts commit c9e7405.
oxyc
force-pushed
the
feature/url-prefix
branch
from
c29d74a to
17aa4b5
Compare
Author
|
Not at all, a command line flag would work just as well. I changed the PR. Note, I didn't run the tests (yet) as I didn't have a local environment set up for behat. |
oxyc
force-pushed
the
feature/url-prefix
branch
from
17aa4b5 to
da63858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10 (comment) Just opening this up for discussion but this might not be the best way since at a glance you might expect the prefix to be validated which it's not. Any thoughts or not looking to add support for this?